Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust conversion of plain object to Transaction (same as v12) #409

Merged
merged 1 commit into from
Mar 21, 2024
Merged

More robust conversion of plain object to Transaction (same as v12) #409

merged 1 commit into from
Mar 21, 2024

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Mar 21, 2024 •
edited
Loading

Undo regression (decrease of robustness) - cast options & versions to number.

@andreibancioiu andreibancioiu self-assigned this Mar 21, 2024
@andreibancioiu andreibancioiu marked this pull request as ready for review March 21, 2024 17:04
@andreibancioiu andreibancioiu merged commit b9415c6 into feat/next Mar 21, 2024
1 check passed
@andreibancioiu andreibancioiu deleted the same-robustness-converter branch March 21, 2024 17:08
@andreibancioiu andreibancioiu mentioned this pull request Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiprianDraghici CiprianDraghici CiprianDraghici approved these changes

@ioandanpopa ioandanpopa ioandanpopa approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @ioandanpopa @CiprianDraghici