Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"protobufjs" simplifications #407

Merged
merged 10 commits into from
Mar 20, 2024
Merged

"protobufjs" simplifications #407

merged 10 commits into from
Mar 20, 2024

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Mar 20, 2024 •
edited
Loading

  • protobufjs is now a peer dependency
  • updated reference towards protobufjs
  • re-generated proto serializer, using a simplified *.proto file
  • typescript definitions for the compiled serializer have been removed (never useful)

References:

@andreibancioiu andreibancioiu self-assigned this Mar 20, 2024
@andreibancioiu andreibancioiu changed the title Proto as optional dependency (experiment) Fix references towards protobufjs (experiment) Mar 20, 2024
@andreibancioiu andreibancioiu changed the base branch from main to feat/next March 20, 2024 15:24
@andreibancioiu andreibancioiu changed the title Fix references towards protobufjs (experiment) "protobufjs" simplifications Mar 20, 2024
@andreibancioiu andreibancioiu marked this pull request as ready for review March 20, 2024 15:26
@andreibancioiu andreibancioiu merged commit 7106a5f into feat/next Mar 20, 2024
1 check passed
@andreibancioiu andreibancioiu deleted the proto-optional branch March 20, 2024 16:04
@andreibancioiu andreibancioiu mentioned this pull request Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

@CiprianDraghici CiprianDraghici CiprianDraghici approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @CiprianDraghici @bogdan-rosianu