Replaced BigNumber with BigInt #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,13 +59,13 @@ export type ITokenPayment = ITokenTransfer; | |||
| export interface ITransactionNext { | |||
| sender: string; | |||
| receiver: string; | |||
| gasLimit: BigNumber.Value; | |||
| gasLimit: bigint; | |||
There was a problem hiding this comment.
| @@ -130,7 +130,7 @@ export class SmartContract implements ISmartContract { | |||
| const nextTx = scNextTransactionFactory.createTransactionForDeploy({ | |||
| sender: deployer, | |||
| bytecode: bytecode, | |||
| gasLimit: gasLimit.valueOf(), | |||
| gasLimit: BigInt(gasLimit.valueOf()), | |||
There was a problem hiding this comment.
Upcasting, because before we had gasLimit as number. This is fine (it's the only good option) 👍
| @@ -32,8 +32,8 @@ describe("test transaction construction", async () => { | |||
| const transaction = Transaction.fromTransactionNext(nextTransaction); | |||
| assert.deepEqual(transaction.getSender(), Address.fromBech32(plainTransactionNextObject.sender)); | |||
| assert.deepEqual(transaction.getReceiver(), Address.fromBech32(plainTransactionNextObject.receiver)); | |||
| assert.equal(transaction.getGasLimit().valueOf(), plainTransactionNextObject.gasLimit); | |||
| assert.equal(transaction.getValue().toString(), plainTransactionNextObject.value); | |||
| assert.equal(transaction.getGasLimit().valueOf().toFixed(0), plainTransactionNextObject.gasLimit.toString()); | |||
There was a problem hiding this comment.
I am not sure why does this work, since transaction.getGasLimit().valueOf() returns a number.
There was a problem hiding this comment.
toString() works fine as well.
src/transaction.ts
Outdated
| @@ -428,9 +428,9 @@ export class Transaction { | |||
| const tx = new Transaction({ | |||
| sender: Address.fromBech32(transaction.sender), | |||
| receiver: Address.fromBech32(transaction.receiver), | |||
| gasLimit: new BigNumber(transaction.gasLimit).toNumber(), | |||
| gasLimit: new BigNumber(transaction.gasLimit.toString()).toNumber(), | |||
There was a problem hiding this comment.
I think here we should do as follows:
| chainID: transaction.chainID, | ||
| value: new BigNumber(transaction.value).toFixed(0), | ||
| value: new BigNumber(transaction.value.toString()).toFixed(0), |
Comment on lines
592
to
593
| bigIntToHex(new BigNumber(options.tokenNonce.toString())), | ||
| bigIntToHex(new BigNumber(options.quantityToBurn.toString())), |
There was a problem hiding this comment.
Perhaps use numberToPaddedHex (which handles bigint). If necessary, maybe handle 0 differently in numberToPaddedHex.
There was a problem hiding this comment.
Replaced with numberToPaddedHex.
andreibancioiu
previously approved these changes
Feb 16, 2024
| @@ -49,7 +49,7 @@ describe("test token management transactions factory", () => { | |||
| assert.deepEqual( | |||
| next.data, | |||
| Buffer.from( | |||
| "issue@4652414e4b@4652414e4b@64@@63616e467265657a65@74727565@63616e57697065@74727565@63616e5061757365@74727565@63616e4368616e67654f776e6572@74727565@63616e55706772616465@66616c7365@63616e4164645370656369616c526f6c6573@66616c7365", | |||
| "issue@4652414e4b@4652414e4b@64@00@63616e467265657a65@74727565@63616e57697065@74727565@63616e5061757365@74727565@63616e4368616e67654f776e6572@74727565@63616e55706772616465@66616c7365@63616e4164645370656369616c526f6c6573@66616c7365", | |||
There was a problem hiding this comment.
confirmed on testnet 👍
src/transaction.ts
Outdated
| new BigNumber(networkConfig.GasPriceModifier) | ||
| ); | ||
| const processingFee = diff.multipliedBy(modifiedGasPrice); | ||
| const diff = transaction.gasLimit- moveBalanceGas; |
There was a problem hiding this comment.
transaction.gasLimit- moveBalanceGas;
=>
transaction.gasLimit - moveBalanceGas;
| @@ -49,7 +49,7 @@ describe("test token management transactions factory", () => { | |||
| assert.deepEqual( | |||
| next.data, | |||
| Buffer.from( | |||
| "issue@4652414e4b@4652414e4b@64@@63616e467265657a65@74727565@63616e57697065@74727565@63616e5061757365@74727565@63616e4368616e67654f776e6572@74727565@63616e55706772616465@66616c7365@63616e4164645370656369616c526f6c6573@66616c7365", | |||
| "issue@4652414e4b@4652414e4b@64@00@63616e467265657a65@74727565@63616e57697065@74727565@63616e5061757365@74727565@63616e4368616e67654f776e6572@74727565@63616e55706772616465@66616c7365@63616e4164645370656369616c526f6c6573@66616c7365", | |||
There was a problem hiding this comment.
confirmed on testnet 👍
bogdan-rosianu
approved these changes
Feb 20, 2024
andreibancioiu
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new v13 release, the functionality added will use
bigintinstead ofBigNumber.