Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed address is not shown on ledger login #1328

Merged
merged 3 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- [Fixed address is not shown on ledger login](https://github.com/multiversx/mx-sdk-dapp/pull/1328)
- [Added support for custom web socket url](https://github.com/multiversx/mx-sdk-dapp/pull/1327)

## [[v3.0.19](https://github.com/multiversx/mx-sdk-dapp/pull/1326)] - 2024-11-28
Expand Down
6 changes: 2 additions & 4 deletions src/UI/TransactionData/components/TransactionDataDecode.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,10 @@ export const TransactionDataDecode = ({
}, [method, data]);

return (
<div
data-testid={DataTestIdsEnum.transactionDataDecode}
className={classNames('transaction-data-decode', className)}
>
<div className={classNames('transaction-data-decode', className)}>
<select
className='transaction-data-decode-select'
data-testid={DataTestIdsEnum.transactionDataDecode}
value={method.value}
onChange={handleSelect}
>
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/login/useLedgerLogin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ export const useLedgerLogin = ({
);
}

await loginUser();
setIsLoading(false);
await loginUser();
} catch (err) {
onLoginFailed(err);
}
Expand Down