Fixed Ledger login #1321
Merged
Fixed Ledger login #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiprianDraghici
approved these changes
Nov 27, 2024
arhtudormorar
approved these changes
Nov 27, 2024
|
maybe add PR description |
# Conflicts: # CHANGELOG.md # src/components/ProviderInitializer/ProviderInitializer.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ledger login with USB no longer works. Instant error occurs and only after multiple clicks it works
Root cause
The ledger account is no longer cleared when error occurs because the provider init failed. The accounts are fetched without an intialised provider, so, it fails instantly. Many race conditions occur.
Fix
Wait for the Ledger/HW provider to be initialized on component mount and fetch the accounts otherwise.
Continue the regular login after this and show errors only if the loading state is true (loading state means the user started to login)