Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
BigNumber
configuration was not properly cleaned up in thestringIsFloat
helper function, thus overwriting the configuration in other helper functions too, creating a race condition.Reproduce
Issue exists on version
3.0.12
of sdk-dapp.Root cause
The cause was the
BigNumber.set
method called globally in thestringIsFloat
helper function.Fix
Create a clone of the
BigNumber
instance and scope it locally, and only change the settings at a local function level.Contains breaking changes
Updated CHANGELOG
Testing