skipDataScamCheck if the the tx is a transfer and the sender == receiver

multiversx · Nov 14, 2024 · 47efb49 · 47efb49
1 parent ca4f4c6
commit 47efb49
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 21 deletions.
diff --git a/src/components/DataDecode/DataDecode.tsx b/src/components/DataDecode/DataDecode.tsx
@@ -1,4 +1,10 @@
-import { Dispatch, SetStateAction, useEffect, useState } from 'react';
+import {
+  Dispatch,
+  ReactNode,
+  SetStateAction,
+  useEffect,
+  useState
+} from 'react';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import BigNumber from 'bignumber.js';
 import { Anchor, Dropdown } from 'react-bootstrap';
@@ -197,13 +203,15 @@ export const DataDecode = ({
   className,
   initialDecodeMethod,
   setDecodeMethod,
-  identifier
+  identifier,
+  children
 }: {
   value: string;
   className?: string;
   initialDecodeMethod?: DecodeMethodEnum;
   setDecodeMethod?: Dispatch<SetStateAction<DecodeMethodEnum>>;
   identifier?: string;
+  children?: ReactNode;
 }) => {
   const defaultDecodeMethod =
     initialDecodeMethod &&
@@ -253,7 +261,7 @@ export const DataDecode = ({
       }`}
     >
       <div className={`form-control textarea ${className ? className : ''}`}>
-        {displayValue}
+        {children ? children : displayValue}
       </div>
       {value && value !== 'N/A' && (
         <div className='d-flex button-holder'>

diff --git a/src/pages/TransactionDetails/components/DataField/DataField.tsx b/src/pages/TransactionDetails/components/DataField/DataField.tsx
@@ -13,15 +13,19 @@ import {
   useGetTransactionUrlHashParams
 } from 'hooks';
 import { transactionsRoutes } from 'routes';
-import { ScamInfoType } from 'types';
+import { ScamInfoType, WithClassnameType } from 'types';
 
-export const DataField = ({
-  data,
-  scamInfo
-}: {
+export interface DataFieldUIType extends WithClassnameType {
   data?: string;
   scamInfo?: ScamInfoType;
-}) => {
+  skipDataScamCheck?: boolean;
+}
+
+export const DataField = ({
+  data,
+  scamInfo,
+  skipDataScamCheck
+}: DataFieldUIType) => {
   const navigate = useNavigate();
   const networkRoute = useNetworkRoute();
   const activeRoute = useActiveRoute();
@@ -59,26 +63,31 @@ export const DataField = ({
     }
   }, [decodeMethod, pathname]);
 
+  const showRawLinks =
+    decodeMethod === DecodeMethodEnum.raw && (showData || skipDataScamCheck);
+  const value = truncate(
+    skipDataScamCheck ? dataString : output,
+    MAX_DISPLAY_TX_DATA_LENGTH
+  );
+
   return (
     <DetailItem title='Input Data' className='data-field'>
-      {showData ? (
-        <div className='textarea form-control col cursor-text mt-1'>
+      <DataDecode
+        value={value}
+        initialDecodeMethod={!id ? dataDecode : DecodeMethodEnum.raw}
+        setDecodeMethod={setDecodeMethod}
+      >
+        {showRawLinks && (
           <Anchorme
             linkComponent={ModalLink}
             target='_blank'
             rel='noreferrer nofollow noopener'
           >
             {stringWithLinks}
           </Anchorme>
-        </div>
-      ) : (
-        <DataDecode
-          value={truncate(output, MAX_DISPLAY_TX_DATA_LENGTH)}
-          initialDecodeMethod={!id ? dataDecode : DecodeMethodEnum.raw}
-          setDecodeMethod={setDecodeMethod}
-        />
-      )}
-      {found && (
+        )}
+      </DataDecode>
+      {found && !skipDataScamCheck && (
         <a href='/#' onClick={show} className='small-font text-muted'>
           {!showData ? 'Show' : 'Hide'} original message
         </a>

diff --git a/...ionDetails/components/TransactionInfo/TransactionDetailsPanel/TransactionDetailsPanel.tsx b/...ionDetails/components/TransactionInfo/TransactionDetailsPanel/TransactionDetailsPanel.tsx
@@ -40,6 +40,7 @@ import { activeNetworkSelector } from 'redux/selectors';
 import {
   TransactionType,
   TransactionActionCategoryEnum,
+  TransactionActionEnum,
   TransactionApiStatusEnum
 } from 'types';
 
@@ -67,6 +68,11 @@ export const TransactionDetailsPanel = ({
   const showTotalTxTokenUsdValue =
     totalTxTokenUsdValue !== new BigNumber(0).toString();
 
+  const skipDataScamCheck =
+    transaction.sender === receiver &&
+    transaction.function === TransactionActionEnum.transfer &&
+    (!transaction.scamInfo || transaction.scamInfo?.type === 'potentialScam');
+
   return (
     <>
       <DetailItem title='Hash'>
@@ -324,7 +330,11 @@ export const TransactionDetailsPanel = ({
         <TransactionWarningMessage transaction={transaction} />
       </DetailItem>
 
-      <DataField data={transaction.data} scamInfo={transaction.scamInfo} />
+      <DataField
+        data={transaction.data}
+        scamInfo={transaction.scamInfo}
+        skipDataScamCheck={skipDataScamCheck}
+      />
 
       {transaction.results && transaction.results?.length > 0 && (
         <DetailItem