-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute only mex in fees collector #990
base: rc/dist-only-mex-fees-collector
Are you sure you want to change the base?
Distribute only mex in fees collector #990
Conversation
Coverage SummaryTotals
FilesExpand
|
Contract comparison - from ae73475 to 8497b70
|
pub trait PairProxy { | ||
#[payable("*")] | ||
#[endpoint(swapTokensFixedInput)] | ||
fn swap_tokens_fixed_input( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not integrate the actual Pair contract and write just a proxy? This way you can make a complete integration test.
@@ -59,6 +55,37 @@ pub trait FeesAccumulationModule: | |||
} | |||
} | |||
|
|||
fn try_swap_to_base_token(&self, payment: &mut EsdtTokenPayment) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works as intended. We want to give all rewards in XMEX. This means we need to either go further by swapping the WEGLD to MEX and accumulate that. Or the other option would be, whenever we claim the rewards for a week, the first claim operation in the week does an extra swap of all the gathered WEGLD to MEX and then we distribuite the total MEX token.
No description provided.