change undistributed rewards code #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
no-more-add-liq-with-locked-tokens
to
rc/v3.0.1.5
November 13, 2024 07:00
An error occurred while trying to automatically change base from
no-more-add-liq-with-locked-tokens
to
rc/v3.0.1.5
November 13, 2024 07:00
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 94d6506 to 64319c1
|
CostinCarabas
approved these changes
Nov 13, 2024
| end_week: Week, | ||
| dest_address: ManagedAddress, | ||
| ) { | ||
| let collect_rewards_offset = USER_MAX_CLAIM_WEEKS + 1; |
There was a problem hiding this comment.
Why use an offset? Why not claiming all the rewards from start_week to end_week?
There was a problem hiding this comment.
It was like this in the initial implementation and I kept it. It makes sense: Users can claim boosted rewards for the past 4 weeks anytime, so you should only collect rewards from 5 weeks onward.
| let caller = self.blockchain().get_caller(); | ||
| require!( | ||
| self.unlocked_token_transfer_whitelist().contains(&caller), | ||
| "May not call this endpoint" |
There was a problem hiding this comment.
Maybe add a more descriptive error msg like Not authorized to call this endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.