Multi bls secpr1 more crypto #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # vmhost/contexts/runtime.go # vmhost/hostCore/host.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.next1 #825 +/- ##
=================================================
+ Coverage 36.23% 36.24% +0.01%
=================================================
Files 49 49
Lines 9246 9316 +70
=================================================
+ Hits 3350 3377 +27
- Misses 5727 5764 +37
- Partials 169 175 +6 ☔ View full report in Codecov by Sentry. |
…o multiBLS-secpr1-more-crypto
ccorcoveanu
reviewed
Feb 15, 2024
| @@ -225,6 +225,9 @@ | |||
| UnmarshalCompressedECC = 270000 | |||
| GenerateKeyECC = 7000000 | |||
| EncodeDERSig = 10000000 | |||
| VerifySecp256r1 = 2000000 | |||
There was a problem hiding this comment.
Alignement issue ^
- are the values ok to be equal for different types of verifications?
There was a problem hiding this comment.
this still seems to be here
| @@ -580,31 +572,6 @@ func (host *vmHost) EpochConfirmed(epoch uint32, _ uint64) { | |||
| } | |||
| } | |||
|
|
|||
| // FixOOGReturnCodeEnabled returns true if the corresponding flag is set | |||
| func (host *vmHost) FixOOGReturnCodeEnabled() bool { | |||
There was a problem hiding this comment.
q: why are all these flags removed?
There was a problem hiding this comment.
Not needed. Not used, should have been cleaned before.
There was a problem hiding this comment.
ok, so unrelated with this PR, just some extra cleanup, got it 👍
andrei-marinica
previously approved these changes
Feb 15, 2024
sasurobert
dismissed
andrei-marinica’s stale review
The base branch was changed.
implementation of GetRelayer, GetOriginal and Enable Readable User Ac…
# Conflicts: # go.mod # go.sum
andrei-marinica
previously approved these changes
Apr 11, 2024
…o multiBLS-secpr1-more-crypto
andrei-marinica
previously approved these changes
Apr 12, 2024
ccorcoveanu
previously approved these changes
Apr 23, 2024
ccorcoveanu
previously approved these changes
Apr 30, 2024
laurci
previously approved these changes
Apr 30, 2024
Macos-latest is now ARM64
ccorcoveanu
approved these changes
Apr 30, 2024
andrei-marinica
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
SHA256 of Wasmer2 libraries, as on 2024-04-12: