Multisig unit tests #249
Merged
Multisig unit tests #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit-tests' into multisig-unit-tests
# Conflicts: # multisig/tests/multisig_blackbox_test.rs
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from ea7ea9b to 31805a0
|
dorin-iancu
previously approved these changes
Nov 5, 2024
CostinCarabas
previously approved these changes
Nov 11, 2024
| .to(MULTISIG_ADDRESS) | ||
| .typed(multisig_proxy::MultisigProxy) | ||
| .distribute_fees_from_child_contracts(dest_address_percentage_pairs) | ||
| .run(); |
There was a problem hiding this comment.
also check that the dest_addresses has the balances? before and after
| .typed(multisig_proxy::MultisigProxy) | ||
| .distribute_fees_from_child_contracts(dest_address_percentage_pairs) | ||
| .returns(ExpectError(4, "Percentages do not add up to 100%")) | ||
| .run(); |
There was a problem hiding this comment.
also check that the dest_addresses has the same balances? before and after
| 4, | ||
| "Cannot transfer to smart contract dest_address", | ||
| )) | ||
| .run(); |
There was a problem hiding this comment.
also check that the dest_addresses has the same balances? before and after
| .typed(multisig_proxy::MultisigProxy) | ||
| .unstake(unstake_amount) | ||
| .returns(ExpectError(4, "can't unstake more than amount staked")) | ||
| .run(); |
There was a problem hiding this comment.
check that the staked amount remains the same
| 4, | ||
| "can't unstake, must keep minimum amount as insurance", | ||
| )) | ||
| .run(); |
There was a problem hiding this comment.
check that the staked amount remains the same
| .returns(ReturnsResult) | ||
| .run(); | ||
|
|
||
| assert_eq!(remaining_stake_relayer2, BigUint::from(2_000u64)); |
| state | ||
| .world | ||
| .check_account(ESDT_SAFE_ADDRESS) | ||
| .esdt_balance(token_id, amount.clone()); |
There was a problem hiding this comment.
check also the storages
| .from(OWNER_ADDRESS) | ||
| .to(MULTISIG_ADDRESS) | ||
| .typed(multisig_proxy::MultisigProxy) | ||
| .add_unprocessed_refund_tx_to_batch(tx_id) |
There was a problem hiding this comment.
we do not have a view for the pending batches. what should i check instead?
There was a problem hiding this comment.
unprocessed_refund_txs(tx_id) has to be cleaned
last_batch_id before and last_batch_id after and should be + 1
There was a problem hiding this comment.
forgot to check earlier, but this endpoint calls the add_unprocessed_refund_tx_to_batch from a mock multi-transfer contract which does not set any storage. this endpoint will be tested from multitransfer directly
| .to(MULTISIG_ADDRESS) | ||
| .typed(multisig_proxy::MultisigProxy) | ||
| .withdraw_refund_fees_for_ethereum(TokenIdentifier::from(WEGLD_TOKEN_ID)) | ||
| .run(); |
There was a problem hiding this comment.
check the balance of the owner
There was a problem hiding this comment.
we are using a mock esdt safe contract, so after multisig calling withdraw_refund_fees_for_ethereum from esdt safe, nothing is happening. maybe i can use a storage mapper to see we actually get here, otherwise the functionality from withdraw_refund_fees_for_ethereum on esdt safe was already unit tested in esdt_safe_blackbox_test.rs
| .from(OWNER_ADDRESS) | ||
| .to(MULTISIG_ADDRESS) | ||
| .typed(multisig_proxy::MultisigProxy) | ||
| .withdraw_transaction_fees(TokenIdentifier::from(WEGLD_TOKEN_ID)) |
There was a problem hiding this comment.
same here. but great observation, i will check also on esdt_safe_blackbox_test.rs the balances. thanks
There was a problem hiding this comment.
then the checks for the balances also on esdt_safe_blackbox_test.rs is enough
CostinCarabas
previously approved these changes
Nov 13, 2024
|
|
||
| let mut board: MultiValueEncoded<StaticApi, ManagedAddress<StaticApi>> = | ||
| MultiValueEncoded::new(); | ||
| board.push(ManagedAddress::from(RELAYER1_ADDRESS.eval_to_array())); |
There was a problem hiding this comment.
I think it's easier to use the to_managed_address() method
RELAYER1_ADDRESS.to_managed_address()
There was a problem hiding this comment.
thanks for the suggestion, indeed easier
dorin-iancu
previously approved these changes
Nov 13, 2024
andreiblt1304
previously approved these changes
Nov 13, 2024
alyn509
previously approved these changes
Nov 13, 2024
evelinemolnar
dismissed stale reviews from CostinCarabas, alyn509, dorin-iancu, and andreiblt1304
via
de97869
CostinCarabas
previously approved these changes
Nov 13, 2024
andreiblt1304
previously approved these changes
Nov 13, 2024
CostinCarabas
dismissed stale reviews from andreiblt1304 and themself
The base branch was changed.
CostinCarabas
approved these changes
Dec 10, 2024
andreiblt1304
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.