bridge-proxy:Only failed transactions are returned #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the callback only in case of error should the transaction be added to eth_failed_transaction_list.
|
Contract comparison - from 7a38dec to f2b0c43
|
dragos-rebegea
previously approved these changes
Feb 12, 2024
dorin-iancu
reviewed
Feb 12, 2024
bridge-proxy/src/bridge-proxy.rs
Outdated
Comment on lines
54
to
59
| match result { | ||
| ManagedAsyncCallResult::Ok(_) => {} | ||
| ManagedAsyncCallResult::Err(_) => { | ||
| self.eth_failed_transaction_list().push_back(tx.clone()); | ||
| } | ||
| } |
There was a problem hiding this comment.
if ManagedAsyncCallResult::Err(_) = result {
self.eth_failed_transaction_list().push_back(tx.clone());
}
dragos-rebegea
previously approved these changes
Feb 12, 2024
dorin-iancu
previously approved these changes
Feb 12, 2024
CostinCarabas
dismissed stale reviews from dorin-iancu and dragos-rebegea
via
f5b5760
dorin-iancu
approved these changes
Feb 13, 2024
dragos-rebegea
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the callback only in case of error should the transaction be added to eth_failed_transaction_list.