Feat/tx with sc call #153
Merged
Feat/tx with sc call #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data is the SC call to be executed on MultiversX side
Send failed transactions from Bridge-Proxy to Multi-Transfer-Esdt
Allow MultiversX SC Calls via Bridge
Framework upgrade 0.42
Fix init arguments
Bridge proxy tests
| } else { | ||
| valid_dest_addresses_list.push(eth_tx.to); | ||
| valid_payments_list.push(EsdtTokenPayment::new(eth_tx.token_id, 0, eth_tx.amount)); | ||
| } | ||
| } | ||
|
|
||
| let payments_after_wrapping = self.wrap_tokens(valid_payments_list); |
There was a problem hiding this comment.
I think we should first try to wrap tokens first, no matter if its a SC-call or not and only then to make a deposit on bridge proxy.
…urn-or-locking # Conflicts: # bridged-tokens-wrapper/Cargo.toml # bridged-tokens-wrapper/meta/Cargo.toml # bridged-tokens-wrapper/wasm/Cargo.lock # bridged-tokens-wrapper/wasm/Cargo.toml # common/eth-address/Cargo.toml # common/fee-estimator-module/Cargo.toml # common/max-bridged-amount-module/Cargo.toml # common/token-module/Cargo.toml # common/transaction/Cargo.toml # common/tx-batch-module/Cargo.toml # esdt-safe/Cargo.toml # esdt-safe/meta/Cargo.toml # esdt-safe/wasm/Cargo.toml # esdt-safe/wasm/src/lib.rs # multi-transfer-esdt/Cargo.toml # multi-transfer-esdt/meta/Cargo.toml # multi-transfer-esdt/wasm/Cargo.lock # multi-transfer-esdt/wasm/Cargo.toml # multi-transfer-esdt/wasm/src/lib.rs # multisig/Cargo.toml # multisig/meta/Cargo.toml # multisig/wasm/Cargo.lock # multisig/wasm/Cargo.toml # multisig/wasm/src/lib.rs
Actions: checks trigger also on feat branches
dragos-rebegea
previously approved these changes
Dec 27, 2023
Adjust tests
Co-authored-by: Rebegea Dragos-Alexandru <[email protected]>
Check tx fail if token is not whitelist or mintBurnAllowed = False
add mintBurn or locking functionality
|
Contract comparison - from 8c1438e to bae95ea
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.