Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navbar in contributor page #332

Closed
wants to merge 7 commits into from
Closed

Add navbar in contributor page #332

wants to merge 7 commits into from

Conversation

souvikpramanikgit
Copy link
Contributor

Issue - #325

image

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2024 •
edited
Loading

✅ Deploy Preview for codeittool ready!

Name Link
🔨 Latest commit 1b03743
🔍 Latest deploy log https://app.netlify.com/sites/codeittool/deploys/6730475109ffbf000877dcc8
😎 Deploy Preview https://deploy-preview-332--codeittool.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@souvikpramanikgit
Copy link
Contributor Author

@multiverseweb

@multiverseweb
Copy link
Owner

Hey @souvikpramanikgit, the sidebar isn't opening in mobile view, kindly fix such minor issues

@souvikpramanikgit
Copy link
Contributor Author

ok let me check

@souvikpramanikgit
Copy link
Contributor Author

Now it's ok,you can check it.

@multiverseweb
Copy link
Owner

multiverseweb commented Nov 9, 2024 •
edited
Loading

@souvikpramanikgit remove the theme button from that page as it is nor working properly and it isn't even required at that page.
Please check such things before sending PRs

@souvikpramanikgit
Copy link
Contributor Author

Now check it.

@multiverseweb
Copy link
Owner

✅ Deploy Preview for codeittool ready!

Name Link
🔨 Latest commit f573bc5
🔍 Latest deploy log https://app.netlify.com/sites/codeittool/deploys/672fab47eb302a0008b06036
😎 Deploy Preview https://deploy-preview-332--codeittool.netlify.app
📱 Preview on mobile
Toggle QR Code...
To edit notification comments on pull requests, go to your Netlify site configuration.

@souvikpramanikgit checkout the sidebar in this deplpoyment preview link. Is it working on your device?

@souvikpramanikgit
Copy link
Contributor Author

yeah,the sidebar is not working after remove the dark light option

@souvikpramanikgit
Copy link
Contributor Author

I find a way, now its working

@souvikpramanikgit
Copy link
Contributor Author

it's working, you can check @multiverseweb

amin-xiv
amin-xiv reviewed Nov 9, 2024
View reviewed changes
Copy link
Contributor

@amin-xiv amin-xiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I don't know why but in the Contributors page the hover animation on the nav bar isn't working, I believe that it would be better if they were present. Thank you.

@multiverseweb
Copy link
Owner

@souvikpramanikgit Yes, it looks fine now. Just uncomment the resources/common_functions.js script at line no. 98 in pages/contributorsSection.html so that the hover effect works on navbar.
image

@souvikpramanikgit
Copy link
Contributor Author

I uncomment the line,but in my system the hover still not working.

@souvikpramanikgit
Copy link
Contributor Author

merge it @multiverseweb

@souvikpramanikgit
Copy link
Contributor Author

@multiverseweb

@aslams2020
Copy link

sanjay-kv/Open-source-Practice#1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amin-xiv amin-xiv amin-xiv left review comments

Assignees

@souvikpramanikgit souvikpramanikgit

Labels
Further Improvement Required gssoc-ext level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@souvikpramanikgit @multiverseweb @aslams2020 @amin-xiv