-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Feature : Progress bar added in home page & contributors page" #310
Conversation
✅ Deploy Preview for codeittool ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from CodeIt
will review it as soon as possible. We appreciate your support in making this project better.
Hey @Edasgh the colors used in progress bar are very different as compared to that of the website. you can use this gradient: Also, decrease the thickness of the bar, maybe 2-3px is fine. |
Ok |
Is this ok? |
@Edasgh yes! It looks good now |
Hey @Edasgh, I think you mistakenly deleted the content after the FAQ section on the landing page. Kindly check it once and let me know if there's a problem on my side. |
No problem on my side, the content after faq section is present there: https://www.loom.com/share/d28579e7046a4e05926d2eac51b459d7?sid=8cec03a5-979a-4f18-b75e-3ab4a2f9c0e4 |
Okay let me check it by merging directly, I don't have my computer right now |
@Edasgh I'm reverting the PR as the same issue arised in the main site and will get back to you by evening. Will resolve the conflicts if I find any. I'm traveling right now, sorry for the inconvenience. |
It's ok |
Hey @multiverseweb , I just found out that this issue might be occurred because I tried to resolve the conflicts here. Should I raise another PR? |
Yes @Edasgh, create another PR for the same, will merge it |
Fixes #302
Changes:
Demo:
https://www.loom.com/share/ac202e0a9c3f4477b12072d0e03ad62d?sid=51e396f1-0f53-45ba-bb77-87015cb16e04