Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setVehicleDirtLevel #3837

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix setVehicleDirtLevel #3837

wants to merge 5 commits into from

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Nov 2, 2024

This PR fixes the long-standing non-functional setVehicleDirtLevel function. The code is based on the source code of SilentPatch by CookiePL, also known as Silent.

image
image

@Fernando-A-Rocha
Copy link
Contributor

Woww!! Thank you for this. Finally we can start having the amazing GTA:SA fixes the community has created over time, on MTA

@Fernando-A-Rocha
Copy link
Contributor

Fixes #3233

@PlatinMTA
Copy link
Contributor

Could we also get a getVehicleDirtLevel? Just because

@FileEX
Copy link
Contributor Author

FileEX commented Nov 2, 2024

Could we also get a getVehicleDirtLevel? Just because

Yeah but in separate PR

@Fernando-A-Rocha
Copy link
Contributor

Could we also get a getVehicleDirtLevel? Just because

Makes sense to have. For example in a custom car wash system where you calculate the price based on the dirt

@TheNormalnij TheNormalnij added enhancement New feature or request feedback Further information is requested bugfix Solution to a bug of any kind labels Nov 14, 2024
@FileEX @TheNormalnij
Update Client/game_sa/CModelInfoSA.h
be0fa46 
Review

Co-authored-by: Uladzislau Nikalayevich <[email protected]>
@lopezloo
Copy link
Member

Does it fix setVehicleDirtLevel function only or it makes vehicles to gain dirt over time too?

@FileEX
Copy link
Contributor Author

FileEX commented Nov 17, 2024

Does it fix setVehicleDirtLevel function only or it makes vehicles to gain dirt over time too?

Probably both cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TracerDS TracerDS TracerDS requested changes

@TheNormalnij TheNormalnij TheNormalnij left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Solution to a bug of any kind enhancement New feature or request feedback Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FileEX @Fernando-A-Rocha @PlatinMTA @lopezloo @TheNormalnij @TracerDS @Dutchman101