Re-enable table sorting by fixing UI in table-detail.vue #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for next-multinet-client ready! 🔨 Explore the source changes: cf19d56 🔍 Inspect the deploy log: https://app.netlify.com/sites/next-multinet-client/deploys/61b927486c3daf00086cb95d 😎 Browse the preview: https://deploy-preview-212--next-multinet-client.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #57
Give a longer description of what this PR addresses and why it's needed
This PR fixes table sorting by not overwriting the original vuetify header, instead choosing to amend the text that the header displays. This allows the vuetify sorting hooks to be used and means we don't need to re-invent the wheel.
Provide pictures/videos of the behavior before and after these changes (optional)
Here's a photo of after the changes, note that the headers have their types (except _key, see TODOs) and that they have sorting icons. The sorting triggers an API call.
Are there any additional TODOs before this PR is ready to go?
TODOs: