Add support for not covered mutants #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDenisov
force-pushed
the
not-covered-mutants
branch
from
c67178e to
36325b4
Compare
stanislaw
approved these changes
Jan 11, 2021
Warwolt
reviewed
Jan 11, 2021
| @@ -44,6 +44,8 @@ | |||
|
|
|||
| --coverage-info string Path to the coverage info file (LLVM's profdata) | |||
|
|
|||
| --include-not-covered Include (but do not run) not covered mutants. Disabled by default | |||
There was a problem hiding this comment.
nit: should this not say "non-covered" mutants? "not covered" sounds a little strange in plural.
There was a problem hiding this comment.
Yeah, it makes sense. There are some contexts (like "Include (but do not run) not covered mutants." above) where "not" is more appropriate, imo. So I think it's better to stick to one form to avoid any confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Mull generates mutations for every function possible. There is an option (
-coverage-info) to use the coverage information obtained from Clang (see the docs for more details) to not mutate unreachable code.Without coverage information, Mull wastes CPU time by checking mutants that cannot be killed. With the coverage information Mull gives misleading reports saying that the mutation coverage is 100% even if only 10% of code was mutated.
This patch adds an option (
-include-not-covered) to also include not covered mutants in the report even when code coverage is provided. The not-covered mutants will show up in the reports, but Mull won't actually mutate anything and won't run tests against not covered mutants.This patch partially addresses #636.
P.S. This is up for review, but I'll do more testing soon as I may have missed some edge cases.