[system] Warns if the hex color contains trailing space #44538
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: system
siriwatknp
changed the title
Netlify deploy previewhttps://deploy-preview-44538--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Nov 26, 2024
| it('warns if the color contains space at the end', () => { | ||
| let result; | ||
| expect(() => { | ||
| result = hexToRgb('#aa0099 '); |
There was a problem hiding this comment.
I think it would be great to test a high-level API, like alpha() instead. I don't see why hexToRgb() is public in the first place.
I don't think so. The point of this PR is to warn if the input is not correct. I am reluctant to process the input at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44504
Test added.