Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Cleanup gatsby examples #27375

Merged
merged 2 commits into from
Jul 23, 2021
Merged

[examples] Cleanup gatsby examples #27375

merged 2 commits into from
Jul 23, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Jul 20, 2021 •
edited
Loading

Follow up of #27357

Changes done:

  • removed gatsby-theme example project
  • removed unnecessary dependency on the gatsby example, remove prepend: true from the cache

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 20, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against ccdf158

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 20, 2021 •
edited
Loading

Tip: https://next.material-ui.com/getting-started/example-projects/#official-examples, we need to remove the link

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 20, 2021
@mnajdova mnajdova requested a review from siriwatknp July 21, 2021 13:54
siriwatknp
siriwatknp approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good.

@mnajdova mnajdova merged commit 2975a51 into mui:next Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnajdova @mui-pr-bot @oliviertassinari @siriwatknp