Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[신승준] 7장: 코딩하는 동안 #69

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[신승준] 7장: 코딩하는 동안 #69

merged 1 commit into from
Sep 9, 2024

Conversation

metacode22
Copy link
Collaborator

흐에!

@metacode22 metacode22 self-assigned this Sep 3, 2024
@github-actions github-actions bot added the 7장 label Sep 3, 2024
100Gyeon
100Gyeon approved these changes Sep 3, 2024
View reviewed changes
7장/신승준.md

디버깅 정보는 공격 매개체다. ATM 기계 화면이나 공항 키오스크, 웹 브라우저 화면에 난데없이 긴 스택 트레이스와 데이터가 가득 나타난다.

> 같은 맥락에서 console.log 좀 지우라는 게 생각 났어요. [NextJS Compiler - removeConsole](https://nextjs.org/docs/architecture/nextjs-compiler#remove-console) 요걸로 지워진 상태로 배포시킬 수 있을 것 같아요.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 요거 몰랐는데 공유 감사합니다👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트를 위한 dataset을 지우는데 써도 좋더라고요 👍 👍

hyesungoh
hyesungoh approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

7장/신승준.md

디버깅 정보는 공격 매개체다. ATM 기계 화면이나 공항 키오스크, 웹 브라우저 화면에 난데없이 긴 스택 트레이스와 데이터가 가득 나타난다.

> 같은 맥락에서 console.log 좀 지우라는 게 생각 났어요. [NextJS Compiler - removeConsole](https://nextjs.org/docs/architecture/nextjs-compiler#remove-console) 요걸로 지워진 상태로 배포시킬 수 있을 것 같아요.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트를 위한 dataset을 지우는데 써도 좋더라고요 👍 👍

@metacode22 metacode22 merged commit 5791a7c into main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100Gyeon 100Gyeon 100Gyeon approved these changes

@hyesungoh hyesungoh hyesungoh approved these changes

@Dongkyuuuu Dongkyuuuu Awaiting requested review from Dongkyuuuu Dongkyuuuu is a code owner

@gutenLEE gutenLEE Awaiting requested review from gutenLEE gutenLEE is a code owner

@Orchemi Orchemi Awaiting requested review from Orchemi Orchemi is a code owner

@sangbooom sangbooom Awaiting requested review from sangbooom sangbooom is a code owner

@Seojunhwan Seojunhwan Awaiting requested review from Seojunhwan Seojunhwan is a code owner

@sjoleee sjoleee Awaiting requested review from sjoleee sjoleee is a code owner

@sumi-0011 sumi-0011 Awaiting requested review from sumi-0011 sumi-0011 is a code owner

Assignees

@metacode22 metacode22

Labels
7장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metacode22 @hyesungoh @100Gyeon