Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[오혜성] 4장: 실용주의 편집증 #26

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[오혜성] 4장: 실용주의 편집증 #26

merged 1 commit into from
Aug 15, 2024

Conversation

hyesungoh
Copy link
Member

😴

@hyesungoh hyesungoh self-assigned this Aug 3, 2024
@github-actions github-actions bot added the 4장 label Aug 3, 2024
100Gyeon
100Gyeon approved these changes Aug 11, 2024
View reviewed changes
4장/오혜성.md
> axios 인터셉터에서 에러가 에러를 던지지 않도록 설정되어 있었어요
>
> 그래서 .. query의 onError 같은 동작이 작동하지 않던 .. 그런 .. 상태였는데요
> '에러 마주보기' 라는 이름의 프로젝트로 전면 수정했던 경험이 있습니다..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋지네요 👍🏻

sangbooom
sangbooom approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@sangbooom sangbooom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻👍🏻

4장/오혜성.md

* 전처리기
+ 찾아내지 못했을 문제를 발견하기 위해
> zod, 테스트 코드가 생각남
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zod 어느정도로 사용하고 계신지 궁금해요 💭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 주로 타입을 확신 할 수 없을 때 사용해요!

ex) form, api response

가장 활발히 사용하고 있는 부분은 api response의 타입을 검증해서 .. 만약 클라이언트에서 선언한 타입과 다를 시 로깅을 남기도록 .. 하고 있심니다

4장/오혜성.md
> 테스트의 숙련도가 높지 않으면, 테스트를 위해 구현체를 바꾸는 경험이 종종 생기는 거 같은데
> 이는 좋은 변화일지? 아니면 하이젠버그적인 문제일지?
> > 물론 뭘 바꾸냐에 따라 다르지만...
> next 컴파일러 옵션에서 data-testid 핸들링 예시: https://github.com/depromeet/na-lab-client/blob/13c0a9e89079bfa0fd8f4d2089db0d9819a299b1/next.config.js#L21-L29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단축평가로 맛깔나게 처리하셨군요 👍🏻

4장/오혜성.md
Comment on lines +69 to +70
> 선언적이라는 키워드 그리고 리액트가 지향하는 방법이라 생각이 듦
> Suspense, ErrorBoundary
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선언적 프로그래밍에 엄청난 도움을 주는 녀석들이지만.. 아직도 라이브러리에 의존적이라는게 아쉬울 뿐입니다..

@hyesungoh hyesungoh merged commit 3a507dc into main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100Gyeon 100Gyeon 100Gyeon approved these changes

@sangbooom sangbooom sangbooom approved these changes

@Dongkyuuuu Dongkyuuuu Awaiting requested review from Dongkyuuuu Dongkyuuuu is a code owner

@gutenLEE gutenLEE Awaiting requested review from gutenLEE gutenLEE is a code owner

@metacode22 metacode22 Awaiting requested review from metacode22 metacode22 is a code owner

@Orchemi Orchemi Awaiting requested review from Orchemi Orchemi is a code owner

@Seojunhwan Seojunhwan Awaiting requested review from Seojunhwan Seojunhwan is a code owner

@sjoleee sjoleee Awaiting requested review from sjoleee sjoleee is a code owner

@sumi-0011 sumi-0011 Awaiting requested review from sumi-0011 sumi-0011 is a code owner

Assignees

@hyesungoh hyesungoh

Labels
4장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyesungoh @sangbooom @100Gyeon