Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[김동규] 챕터 4: 액션에서 계산 빼내기 #31

Merged
merged 1 commit into from
Apr 27, 2024
Merged

[김동규] 챕터 4: 액션에서 계산 빼내기 #31

merged 1 commit into from
Apr 27, 2024

Conversation

Dongkyuuuu
Copy link
Contributor

완료!

hyesungoh
hyesungoh approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !! 👍 👍 👍 👍 👍

챕터_4/챕터4:김동규.md
Comment on lines +40 to +43
```생각 & 의견
역할이 명확히 분리되고 함수형 프로그래밍 관점에서 액션이 많이 줄어든 것 같긴합니다.
평소에 코드 분리하면서 이런식으로 많이 분리하려고 노력했던 것 같은데 확실히 책에서 이야기 해주는
"액션" "계산" "데이터" 로 분리해서 생각하니 엄청 편하게 다가오네요
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅈㅇㅈ합니다

챕터_4/챕터4:김동규.md
Comment on lines +45 to +47
다만,오히려 너무 많은 서브루틴을 통한 코드 파편화
이로인한 너무많은 입력을 받아야 되는 것
이런 문제들이 한켠으로는 생각이드는데 어떻게 생각하시나요?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 중용...이 중요할 거 같다고 느꼈어요 🤔

비즈니스 도메인을 기준으로 추상화하는 방법이 힌트가 될 거 같기도 하구요!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

비즈니스 도메인을 기준으로 한다는 생각을 크게 안해봤었네요 🤔
당장 함수형으로 어떤 코드를 작성하지는 모르겠지만 고민해봄직한 문제 같네요 ㅋㅋㅋㅋㅋㅋ

@Dongkyuuuu Dongkyuuuu merged commit 1beca43 into main Apr 27, 2024
1 check passed
@Dongkyuuuu Dongkyuuuu deleted the 챕터4/김동규 branch April 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyesungoh hyesungoh hyesungoh approved these changes

@oyeon-kwon oyeon-kwon Awaiting requested review from oyeon-kwon oyeon-kwon is a code owner

@sensecodevalue sensecodevalue Awaiting requested review from sensecodevalue sensecodevalue is a code owner

@Seojunhwan Seojunhwan Awaiting requested review from Seojunhwan Seojunhwan is a code owner

@sangbooom sangbooom Awaiting requested review from sangbooom sangbooom is a code owner

@noy3928 noy3928 Awaiting requested review from noy3928

@gutenLEE gutenLEE Awaiting requested review from gutenLEE gutenLEE is a code owner

Assignees

@Dongkyuuuu Dongkyuuuu

Labels
챕터_4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dongkyuuuu @hyesungoh