Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-2950] Changed data migration error messages while cancelling #2217

Merged
merged 6 commits into from
Dec 9, 2024
Merged

[CP-2950] Changed data migration error messages while cancelling #2217

merged 6 commits into from
Dec 9, 2024

Conversation

mkurczewski
Copy link
Collaborator

@mkurczewski mkurczewski commented Dec 4, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-2950

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@mkurczewski mkurczewski marked this pull request as ready for review December 4, 2024 12:44
@mkurczewski mkurczewski changed the title [CP-2950] Changed data migration error messages [CP-2950] Changed data migration error messages while cancelling Dec 4, 2024
dkarski
dkarski previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@dkarski dkarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me, but check for regression in detach before test & merge to develop.

libs/device-manager/feature/src/helpers/is-data-migration-abort-due-to-detach.ts Outdated Show resolved Hide resolved
dkarski
dkarski previously approved these changes Dec 5, 2024
View reviewed changes
@mkurczewski mkurczewski requested a review from dkarski December 5, 2024 13:21
@mkurczewski mkurczewski merged commit 99b1158 into develop Dec 9, 2024
9 checks passed
@mkurczewski mkurczewski deleted the CP-2950-fix branch December 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarski dkarski dkarski approved these changes

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

Assignees

@mkurczewski mkurczewski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurczewski @dkarski