Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-3170] Minor refactor of device-flash #2128

Merged
merged 4 commits into from
Oct 16, 2024
Merged

[CP-3170] Minor refactor of device-flash #2128

merged 4 commits into from
Oct 16, 2024

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Oct 15, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-3170

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski self-assigned this Oct 15, 2024
@dkarski dkarski marked this pull request as draft October 15, 2024 07:47
@dkarski dkarski marked this pull request as ready for review October 15, 2024 07:48
@dkarski dkarski requested a review from mkurczewski October 16, 2024 06:37
@dkarski dkarski merged commit 3bfe9ac into CP-3170 Oct 16, 2024
7 checks passed
@dkarski dkarski deleted the CP-3170-refactor branch October 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurczewski mkurczewski mkurczewski approved these changes

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

Assignees

@dkarski dkarski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarski @mkurczewski