Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-2995] Extract headlineMessage logic into a temporary hook #2109

Closed
wants to merge 1 commit into from
Closed

[CP-2995] Extract headlineMessage logic into a temporary hook #2109

wants to merge 1 commit into from

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Oct 4, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-2995

📝 Description ️

This PR moves the logic for creating the headlineMessage into a temporary hook called useTemporaryHeadlineMessage.

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski force-pushed the CP-2995-extract-temporary-headline-message-hook branch from aadb5a7 to 9c0b1a4 Compare October 4, 2024 07:20
@dkarski dkarski closed this Oct 4, 2024
@dkarski dkarski deleted the CP-2995-extract-temporary-headline-message-hook branch October 22, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

@mkurczewski mkurczewski Awaiting requested review from mkurczewski

Assignees

@dkarski dkarski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dkarski