Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-3004] Refactored layout propagation for generic components #2082

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[CP-3004] Refactored layout propagation for generic components #2082

merged 1 commit into from
Sep 25, 2024

Conversation

mkurczewski
Copy link
Collaborator

@mkurczewski mkurczewski commented Sep 25, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-3004

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@mkurczewski mkurczewski merged commit 8711cb5 into CP-2995 Sep 25, 2024
4 of 7 checks passed
@mkurczewski mkurczewski deleted the CP-3004-layout-refactor branch September 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarski dkarski dkarski approved these changes

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

Assignees

@mkurczewski mkurczewski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurczewski @dkarski