Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-3004] Added toast component #2080

Merged
merged 6 commits into from
Sep 25, 2024
Merged

[CP-3004] Added toast component #2080

merged 6 commits into from
Sep 25, 2024

Conversation

mkurczewski
Copy link
Collaborator

@mkurczewski mkurczewski commented Sep 25, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-3004

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

dkarski
dkarski approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@dkarski dkarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

I did a quick review and only had some minor comments. From me, it's approved—please include what you consider important and merge without additional checking, so we don't block the queue.

libs/generic-view/feature/src/lib/generic-toasts.tsx Outdated Show resolved Hide resolved
libs/generic-view/feature/src/lib/generic-toasts.tsx
const toastsToRender = useSelector((state: ReduxRootState) =>
selectToastsToRender(state, { viewKey })
)
const toastsToRenderDependency = JSON.stringify(toastsToRender)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here: const toastsToRenderDependency = JSON.stringify(toastsToRender)? Is it to work around the issue of array reference changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave this topic for the next sync

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's discuss it later.

libs/generic-view/store/src/lib/toasts/reducer.ts Outdated Show resolved Hide resolved
libs/generic-view/ui/src/lib/interactive/toast/toast.tsx Outdated Show resolved Hide resolved
@mkurczewski mkurczewski merged commit be4fcba into CP-2995 Sep 25, 2024
3 of 6 checks passed
@mkurczewski mkurczewski deleted the CP-3004-toast branch September 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarski dkarski dkarski approved these changes

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

Assignees

@mkurczewski mkurczewski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurczewski @dkarski