Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-2607] Update Electron to Latest Version #1963

Closed
wants to merge 73 commits into from
Closed

[CP-2607] Update Electron to Latest Version #1963

wants to merge 73 commits into from

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Jul 9, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-2607

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

dkarski added 30 commits June 16, 2024 07:50
@dkarski
[CP-2898] device-manager generated
6bc6ee0
@dkarski
[CP-2898] device-protocol generated
958502a
@dkarski
[CP-2898] core-device generated
14c6e2e
@dkarski
[CP-2898] Moved DeviceManager to a separate library with modular depe…
1532e6f 
…ndencies
@dkarski
[CP-2898] Rename all deviceManager to deviceProtocolService
afd1460
@dkarski
[CP-2898] move useDebouncedEventsHandler to "shared/utils"
2b11615
@dkarski
[CP-2898] Change the strategy of the device selects (API & Core) for mds
06348cd
@dkarski
[CP-2898] Split listeners relative to manage core device to separate …
bc23076 
…effects in lib
@dkarski
[CP-2898] Add modifiers reducer to manage api devices
f572e2f
@dkarski
[CP-2898] Handle error case when getAPIConfig request rejected
1e9620f
@dkarski
[CP-2898] active-device-registry generated
1602440
@dkarski
[CP-2898] split active-device-registry from device-manager
ee12f29
@dkarski
[CP-2898] Eliminate duplicate activeDevice after merging state slices
35527a3
@dkarski
[CP-2898] Resolve conflicts after rebase with develop
6409a51
@dkarski
[CP-2898] Commit broken png imports to fix
1956d24
@dkarski
[CP-2898] wip
54ef882
@dkarski
[CP-2898] PNG fixed
6e6f86b
@dkarski
[CP-2898] displayname & sourceRootin config fixed
a0c836a
@dkarski
Revert "[CP-2898] wip"
44ee8e3 
This reverts commit 54ef882.
@dkarski
[CP-2898] fix tests in device-protocol
7e73751
@dkarski
[CP-2898] improve useHandleDevicesDetached logic to handle just api d…
c4307ba 
…eviceDetachedEvents
@dkarski
[CP-2898] Rename deviceProtocolService to deviceProtocol
bf98820
@dkarski
[CP-2898] Split Device Manager into Multiple Modules (#1927)
84279e2
@dkarski
Merge branch 'CP-2898' into CP-2898-device-selects-change-strategy
1af60e0
@dkarski
[CP-2898] Change Strategy for Device Selects (API & Core) (#1928)
2f675aa
@dkarski
[CP-2898] Extract Active Device Management to Dedicated Module (#1929)
dd38e20
@dkarski
[CP-2898] Fixed lastRefresh mechanism to handle race condition
7c237b5
@dkarski
[CP-2898] fix after review (#1931)
58c34d1
@dkarski
Merge branch 'develop' into CP-2898
46a6309
@dkarski
Revert "disable HttpClientService for axios.create (#1932)"
aa6b87b 
This reverts commit be20b35.
mkurczewski
mkurczewski previously approved these changes Jul 22, 2024
View reviewed changes
@lkowalczyk87 lkowalczyk87 dismissed mkurczewski’s stale review August 7, 2024 14:04

The merge-base changed after approval.

@dkarski
Copy link
Member Author

dkarski commented Aug 9, 2024

Changing the pull request status to draft due to an upcoming vacation and the lack of an environment for performance testing on an M1 processor.

@dkarski dkarski removed the QA label Aug 9, 2024
@dkarski dkarski marked this pull request as draft August 9, 2024 07:58
@dkarski
Copy link
Member Author

dkarski commented Dec 3, 2024

The pull request was closed due to a lack of response in addressing the performance issue, caused by other team priorities.

@dkarski dkarski closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurczewski mkurczewski mkurczewski left review comments

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

Assignees

@dkarski dkarski

Labels
enhancement Non-functional improvement / developers' tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkarski @mkurczewski @robertmudi @tomaszmaleckimudita