Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2151] MC update badge status enhancements #1497

Merged
merged 59 commits into from
Oct 25, 2023
Merged

Conversation

OskarMichalkiewicz
Copy link
Contributor

@OskarMichalkiewicz OskarMichalkiewicz commented Oct 19, 2023

JIRA Reference: CP-2151

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@OskarMichalkiewicz OskarMichalkiewicz temporarily deployed to development October 19, 2023 09:53 — with GitHub Actions Inactive
@OskarMichalkiewicz OskarMichalkiewicz marked this pull request as ready for review October 19, 2023 10:54
dkarski
dkarski previously approved these changes Oct 19, 2023
@OskarMichalkiewicz OskarMichalkiewicz temporarily deployed to development October 19, 2023 12:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0136504) 76.81% compared to head (b644f80) 75.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1497      +/-   ##
===========================================
- Coverage    76.81%   75.64%   -1.17%     
===========================================
  Files          906      907       +1     
  Lines        13611    13620       +9     
  Branches      2048     2051       +3     
===========================================
- Hits         10455    10303     -152     
- Misses        2581     2742     +161     
  Partials       575      575              
Files Coverage Δ
...s/app/src/settings/actions/load-settings.action.ts 91.66% <ø> (ø)
...s/actions/set-checking-for-update-failed.action.ts 100.00% <100.00%> (ø)
...ages/app/src/settings/reducers/settings.reducer.ts 96.15% <100.00%> (+0.15%) ⬆️
.../src/settings/components/about/about.component.tsx 20.83% <0.00%> (+3.59%) ⬆️
...c/settings/components/about/about-ui.component.tsx 86.56% <88.46%> (+3.80%) ⬆️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OskarMichalkiewicz OskarMichalkiewicz temporarily deployed to development October 24, 2023 20:42 — with GitHub Actions Inactive
@OskarMichalkiewicz OskarMichalkiewicz temporarily deployed to development October 25, 2023 06:37 — with GitHub Actions Inactive
@dkarski dkarski force-pushed the develop branch 2 times, most recently from 1cc263b to 5bda7d3 Compare October 25, 2023 07:15
@OskarMichalkiewicz OskarMichalkiewicz temporarily deployed to development October 25, 2023 09:58 — with GitHub Actions Inactive
@OskarMichalkiewicz OskarMichalkiewicz merged commit f6946e1 into develop Oct 25, 2023
3 of 4 checks passed
@OskarMichalkiewicz OskarMichalkiewicz deleted the CP-2151 branch October 25, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants