Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-XXX] Nexus files refactored #1493

Merged
merged 5 commits into from
Oct 18, 2023
Merged

[CP-XXX] Nexus files refactored #1493

merged 5 commits into from
Oct 18, 2023

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Oct 18, 2023

JIRA Reference: [CP-XXX]

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski requested a review from MaciejMDDV October 18, 2023 07:50
@dkarski dkarski marked this pull request as ready for review October 18, 2023 07:50
@dkarski dkarski changed the base branch from develop to main October 18, 2023 07:50
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cd43b82) 76.42% compared to head (69b4c6c) 76.43%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   76.42%   76.43%   +0.01%     
==========================================
  Files         920      920              
  Lines       13703    13701       -2     
  Branches     2049     2047       -2     
==========================================
  Hits        10473    10473              
  Misses       2652     2652              
+ Partials      578      576       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MaciejMDDV MaciejMDDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wygląda dobrze, dajesz

@dkarski dkarski merged commit ecdec59 into main Oct 18, 2023
5 checks passed
@dkarski dkarski deleted the nexus-refactor branch October 18, 2023 10:48
dkarski added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants