-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-2079] Merge enums used in invoking methods between main and renderer #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
codestorybro,
dkarski,
lkowalczyk87 and
OskarMichalkiewicz
October 17, 2023 14:53
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1492 +/- ##
===========================================
+ Coverage 76.45% 76.82% +0.36%
===========================================
Files 920 906 -14
Lines 13703 13611 -92
Branches 2049 2047 -2
===========================================
- Hits 10477 10456 -21
+ Misses 2651 2581 -70
+ Partials 575 574 -1
☔ View full report in Codecov by Sentry. |
lkowalczyk87
previously approved these changes
Oct 18, 2023
patryk-sierzega
force-pushed
the
CP-2079
branch
from
October 18, 2023 08:20
e3617cc
to
a9cb7bd
Compare
patryk-sierzega
temporarily deployed
to
development
October 18, 2023 08:20 — with
GitHub Actions
Inactive
patryk-sierzega
temporarily deployed
to
development
October 18, 2023 08:22 — with
GitHub Actions
Inactive
patryk-sierzega
temporarily deployed
to
development
October 18, 2023 08:51 — with
GitHub Actions
Inactive
patryk-sierzega
force-pushed
the
CP-2079
branch
from
October 18, 2023 09:06
ec9aa9a
to
a9cb7bd
Compare
patryk-sierzega
temporarily deployed
to
development
October 18, 2023 09:06 — with
GitHub Actions
Inactive
dkarski
previously approved these changes
Oct 18, 2023
dkarski
dismissed stale reviews from lkowalczyk87 and themself
October 18, 2023 10:52
The merge-base changed after approval.
patryk-sierzega
temporarily deployed
to
development
October 19, 2023 09:13 — with
GitHub Actions
Inactive
OskarMichalkiewicz
approved these changes
Oct 19, 2023
dkarski
added a commit
that referenced
this pull request
Oct 20, 2023
…rer (#1492) Co-authored-by: Daniel Karski <[email protected]>
dkarski
added a commit
that referenced
this pull request
Oct 23, 2023
…rer (#1492) Co-authored-by: Daniel Karski <[email protected]>
dkarski
added a commit
that referenced
this pull request
Oct 24, 2023
…rer (#1492) Co-authored-by: Daniel Karski <[email protected]>
dkarski
added a commit
that referenced
this pull request
Oct 25, 2023
…rer (#1492) Co-authored-by: Daniel Karski <[email protected]>
dkarski
pushed a commit
that referenced
this pull request
Oct 25, 2023
dkarski
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Reference: CP-2079
📝 Description ️
💪 Checklist before requesting a review - nice to have
❗ Checklist before merging a pull request