Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2079] Merge enums used in invoking methods between main and renderer #1492

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

patryk-sierzega
Copy link
Contributor

@patryk-sierzega patryk-sierzega commented Oct 17, 2023

JIRA Reference: CP-2079

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (29f665a) 76.45% compared to head (71ba3a5) 76.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1492      +/-   ##
===========================================
+ Coverage    76.45%   76.82%   +0.36%     
===========================================
  Files          920      906      -14     
  Lines        13703    13611      -92     
  Branches      2049     2047       -2     
===========================================
- Hits         10477    10456      -21     
+ Misses        2651     2581      -70     
+ Partials       575      574       -1     
Files Coverage Δ
...er/controllers/analytic-data-tracker.controller.ts 86.36% <100.00%> (ø)
...pp/src/core/initializers/controller.initializer.ts 90.00% <100.00%> (-0.91%) ⬇️
...pp/src/settings/controllers/settings.controller.ts 100.00% <100.00%> (ø)
...es/app/src/backup/controllers/backup.controller.ts 0.00% <0.00%> (ø)
...app/src/contacts/controllers/contact.controller.ts 0.00% <0.00%> (ø)
...rc/crash-dump/controllers/crash-dump.controller.ts 0.00% <0.00%> (ø)
.../src/data-sync/controllers/data-sync.controller.ts 0.00% <0.00%> (ø)
...ystem/controllers/device-file-system.controller.ts 0.00% <0.00%> (ø)
.../device-info/controllers/device-info.controller.ts 0.00% <0.00%> (ø)
...rc/device-log/controllers/device-log.controller.ts 0.00% <0.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lkowalczyk87
lkowalczyk87 previously approved these changes Oct 18, 2023
@patryk-sierzega patryk-sierzega temporarily deployed to development October 18, 2023 08:20 — with GitHub Actions Inactive
@patryk-sierzega patryk-sierzega temporarily deployed to development October 18, 2023 08:22 — with GitHub Actions Inactive
@patryk-sierzega patryk-sierzega temporarily deployed to development October 18, 2023 08:51 — with GitHub Actions Inactive
@patryk-sierzega patryk-sierzega temporarily deployed to development October 18, 2023 09:06 — with GitHub Actions Inactive
dkarski
dkarski previously approved these changes Oct 18, 2023
@dkarski dkarski dismissed stale reviews from lkowalczyk87 and themself October 18, 2023 10:52

The merge-base changed after approval.

@patryk-sierzega patryk-sierzega temporarily deployed to development October 19, 2023 09:13 — with GitHub Actions Inactive
@patryk-sierzega patryk-sierzega merged commit 302c172 into develop Oct 19, 2023
3 of 4 checks passed
@patryk-sierzega patryk-sierzega deleted the CP-2079 branch October 19, 2023 10:12
dkarski added a commit that referenced this pull request Oct 20, 2023
dkarski added a commit that referenced this pull request Oct 23, 2023
dkarski added a commit that referenced this pull request Oct 24, 2023
dkarski added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants