Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Release v2.2.3 - to stage (#1426)" #1433

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

patryk-sierzega
Copy link
Contributor

This reverts commit 3f9b66f.

JIRA Reference: [CP-XXX]

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (3f9b66f) 76.65% compared to head (a956279) 76.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #1433      +/-   ##
==========================================
- Coverage   76.65%   76.59%   -0.07%     
==========================================
  Files         921      915       -6     
  Lines       13702    13640      -62     
  Branches     2053     2041      -12     
==========================================
- Hits        10503    10447      -56     
+ Misses       2618     2610       -8     
- Partials      581      583       +2     
Files Coverage Δ
...s-select-modal/contacts-select-modal.component.tsx 100.00% <100.00%> (ø)
...c-contacts-modal/sync-contacts-modal.component.tsx 93.33% <100.00%> (+2.15%) ⬆️
...t-item/virtualized-contact-list-item.component.tsx 94.82% <ø> (ø)
.../helpers/contacts-filter/contacts-filter.helper.ts 100.00% <100.00%> (ø)
...p/src/contacts/selectors/contacts-hash.selector.ts 100.00% <100.00%> (ø)
...acts/selectors/favourite-contacts-hash.selector.ts 92.30% <100.00%> (ø)
...s/app/src/contacts/selectors/flat-list.selector.ts 100.00% <100.00%> (ø)
.../selectors/get-contact-by-phone-number.selector.ts 100.00% <100.00%> (ø)
packages/app/src/contacts/selectors/index.ts 100.00% <100.00%> (ø)
...ors/is-contact-created-by-phone-number.selector.ts 100.00% <100.00%> (ø)
... and 30 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patryk-sierzega patryk-sierzega merged commit 94fa0b7 into stage Oct 10, 2023
2 of 4 checks passed
@patryk-sierzega patryk-sierzega deleted the revert-2.2.3 branch October 10, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants