Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2201] Modal designs update for CP-2190, CP-2191 and CP-2192 #1430

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

OskarMichalkiewicz
Copy link
Contributor

@OskarMichalkiewicz OskarMichalkiewicz commented Oct 9, 2023

JIRA Reference: CP-2201

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

patryk-sierzega
patryk-sierzega previously approved these changes Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (edaa580) 76.42% compared to head (fe70aee) 76.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1430      +/-   ##
===========================================
+ Coverage    76.42%   76.43%   +0.01%     
===========================================
  Files          920      920              
  Lines        13706    13701       -5     
  Branches      2051     2047       -4     
===========================================
- Hits         10475    10473       -2     
+ Misses        2655     2652       -3     
  Partials       576      576              
Files Coverage Δ
...alid-files-modal/invalid-files-modal.component.tsx 95.23% <100.00%> (-0.60%) ⬇️
...c/connecting/components/error-connecting-modal.tsx 94.73% <75.00%> (-5.27%) ⬇️
...c-contacts-modal/sync-contacts-modal.component.tsx 88.57% <71.42%> (-2.61%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

patryk-sierzega
patryk-sierzega previously approved these changes Oct 9, 2023
@OskarMichalkiewicz OskarMichalkiewicz merged commit 37ba5b0 into develop Oct 10, 2023
2 of 3 checks passed
@OskarMichalkiewicz OskarMichalkiewicz deleted the CP-2201 branch October 10, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants