Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2196] Force issues resolved #1429

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Oct 9, 2023

JIRA Reference: CP-2196

📝 Description ️

TODO

  • handle build error ➡️ (...) npm ERR! gyp ERR! stack Error: "make" failed with exit code: 2 (...)
  • handle the issue of the application not running on Windows and Linux when building it on a Mac
  • update & resolve conflicts for [email protected]

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski force-pushed the CP-2196-step-by-step-force-issue branch 2 times, most recently from 9053779 to 97b25a1 Compare October 10, 2023 06:56
@dkarski dkarski force-pushed the CP-2196-step-by-step-force-issue branch from 0fb6d6b to cf50376 Compare October 12, 2023 10:25
@dkarski dkarski self-assigned this Oct 12, 2023
@dkarski dkarski marked this pull request as ready for review October 18, 2023 07:09
@dkarski dkarski merged commit 4790327 into CP-2196-step-by-step Oct 18, 2023
1 of 2 checks passed
@dkarski dkarski deleted the CP-2196-step-by-step-force-issue branch October 18, 2023 07:10
lkowalczyk87 added a commit that referenced this pull request Oct 27, 2023
dkarski added a commit that referenced this pull request Nov 8, 2023
dkarski added a commit that referenced this pull request Nov 8, 2023
dkarski added a commit that referenced this pull request Nov 8, 2023
dkarski added a commit that referenced this pull request Nov 8, 2023
patryk-sierzega pushed a commit that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants