Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-1996] [FIX] [Backup] Backup in progress + device change, results with (incorrect) force update modal #1428

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

patryk-sierzega
Copy link
Contributor

@patryk-sierzega patryk-sierzega commented Oct 6, 2023

JIRA Reference: CP-1996

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3b470b8) 76.40% compared to head (7d9773d) 76.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1428      +/-   ##
===========================================
+ Coverage    76.40%   76.42%   +0.01%     
===========================================
  Files          920      920              
  Lines        13709    13706       -3     
  Branches      2053     2051       -2     
===========================================
  Hits         10475    10475              
+ Misses        2656     2655       -1     
+ Partials       578      576       -2     
Files Coverage Δ
packages/app/src/device/actions/base.action.ts 100.00% <100.00%> (ø)
...-update-need/check-for-force-update-need.action.ts 90.47% <ø> (+7.14%) ⬆️
...ctions/check-for-update/check-for-update.action.ts 85.71% <ø> (+5.27%) ⬆️
packages/app/src/device/reducers/device.reducer.ts 66.66% <33.33%> (-0.73%) ⬇️
...e-device-detached/handle-device-detached.action.ts 50.00% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patryk-sierzega patryk-sierzega changed the title [CP-1996] [FIX[ [Backup] Backup in progress + device change, results with (incorrect) force update modal [CP-1996] [FIX] [Backup] Backup in progress + device change, results with (incorrect) force update modal Oct 6, 2023
@patryk-sierzega patryk-sierzega merged commit edaa580 into develop Oct 10, 2023
2 of 3 checks passed
@patryk-sierzega patryk-sierzega deleted the CP-1996-2 branch October 10, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants