Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cp 2190 cp 2191 cp 2192 #1427

Closed
wants to merge 2 commits into from

Conversation

OskarMichalkiewicz
Copy link
Contributor

Jira: [CP-XXX]

Description

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce
Screenshots // put images here

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (32147ef) 76.65% compared to head (371efa1) 76.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1427      +/-   ##
===========================================
- Coverage    76.65%   76.62%   -0.03%     
===========================================
  Files          921      919       -2     
  Lines        13702    13660      -42     
  Branches      2053     2049       -4     
===========================================
- Hits         10503    10467      -36     
+ Misses        2618     2613       -5     
+ Partials       581      580       -1     
Files Coverage Δ
...c-contacts-modal/sync-contacts-modal.component.tsx 93.33% <100.00%> (+2.15%) ⬆️
...kages/app/src/files-manager/actions/base.action.ts 100.00% <ø> (ø)
...mponents/files-manager/files-manager.component.tsx 62.11% <ø> (+0.38%) ⬆️
...oad-files-modals/upload-files-modals.component.tsx 97.22% <ø> (-0.08%) ⬇️
...rc/files-manager/reducers/files-manager.reducer.ts 77.14% <ø> (+2.14%) ⬆️
...ui/components/modal-dialog/modal-dialog.styles.tsx 100.00% <100.00%> (ø)
...s-manager/helpers/check-files-extensions.helper.ts 80.00% <75.00%> (-7.50%) ⬇️
...pp/src/files-manager/actions/upload-file.action.ts 57.62% <50.00%> (+1.88%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OskarMichalkiewicz OskarMichalkiewicz deleted the revert_CP-2190_CP-2191_CP-2192 branch October 5, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant