[CP-2000] [Messages] Search results seems to be in random order. #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dkarski,
lkowalczyk87 and
OskarMichalkiewicz
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1408 +/- ##
===========================================
- Coverage 76.68% 76.67% -0.02%
===========================================
Files 918 921 +3
Lines 13665 13696 +31
Branches 2040 2051 +11
===========================================
+ Hits 10479 10501 +22
- Misses 2606 2616 +10
+ Partials 580 579 -1
☔ View full report in Codecov by Sentry. |
dkarski
previously approved these changes
Sep 29, 2023
| @@ -53,7 +53,7 @@ const mapStateToProps = (state: RootModel & ReduxRootState) => { | |||
| allItemsSelected: state.contacts.selectedItems.allItemsSelected, | |||
| resultState: contacts.resultState, | |||
| contactList: contactsList, | |||
| flatList: flatListSelector(state), | |||
| contacts: contactsSelector(state), | |||
| * For licensing, see https://github.com/mudita/mudita-center/blob/master/LICENSE.md | ||
| */ | ||
|
|
||
| export const sortByLastNameAscending = <T extends { lastName?: string }>( |
There was a problem hiding this comment.
The function name seems to be isn't equal to a file name. Is it intentional?
There was a problem hiding this comment.
nope :D forget about it, thanks
| import { ExportContactFailedModal } from "../export-contact-failed-modal/export-contact-failed-modal.component" | ||
| import { applyValidationRulesToImportedContacts } from "App/contacts/helpers/apply-validation-rules-to-imported-contacts/apply-validation-rules-to-imported-contacts" | ||
| import { ExportContactsResult } from "App/contacts/constants" | ||
| import DeleteContactsPopup from "./delete-contacts-popup/delete-contacts-popup.component" | ||
| import { differenceWith, isEqual } from "lodash" | ||
| import { filterContacts } from "App/messages/helpers/messages.helpers" |
There was a problem hiding this comment.
I'm not sure, so I'll ask if contact filtering should be the domain of messages? 🤔
…er if they select more files than they can add within the limit [Harmony] (#1402) Co-authored-by: Łukasz Kowalczyk <[email protected]> Co-authored-by: patryk-sierzega <[email protected]> Co-authored-by: Łukasz Kowalczyk <[email protected]> Co-authored-by: Daniel Karski <[email protected]>
dkarski
previously approved these changes
Sep 29, 2023
dkarski
dismissed
their stale review
The merge-base changed after approval.
dkarski
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: CP-2000
Description