Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2193] [Mudita News] First article has a space before its title #1399

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

patryk-sierzega
Copy link
Contributor

@patryk-sierzega patryk-sierzega commented Sep 26, 2023

Jira: CP-2193

Description

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce
Screenshots // put images here

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (53f17cc) 76.63% compared to head (f70f037) 76.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1399      +/-   ##
===========================================
+ Coverage    76.63%   76.65%   +0.01%     
===========================================
  Files          921      922       +1     
  Lines        13668    13675       +7     
  Branches      2040     2040              
===========================================
+ Hits         10475    10482       +7     
  Misses        2609     2609              
  Partials       584      584              
Files Coverage Δ
packages/app/src/news/reducers/index.ts 100.00% <100.00%> (ø)
packages/app/src/news/reducers/news.helper.ts 100.00% <100.00%> (ø)
packages/app/src/news/reducers/news.reducer.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patryk-sierzega patryk-sierzega merged commit a55d2ef into develop Sep 26, 2023
4 checks passed
@patryk-sierzega patryk-sierzega deleted the CP-2193 branch September 26, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants