[CP-1729] [Contacts] [Performance] Deleting large amount of contacts at once brakes connection between Center and Pure #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patryk-sierzega
requested review from
lkowalczyk87,
OskarMichalkiewicz and
dkarski
and removed request for
lkowalczyk87 and
OskarMichalkiewicz
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1398 +/- ##
===========================================
+ Coverage 76.62% 76.63% +0.01%
===========================================
Files 921 921
Lines 13672 13668 -4
Branches 2039 2040 +1
===========================================
- Hits 10476 10475 -1
+ Misses 2613 2609 -4
- Partials 583 584 +1
☔ View full report in Codecov by Sentry. |
dkarski
force-pushed
the
develop
branch
2 times, most recently
from
fdea4fe to
51d86f7
Compare
OskarMichalkiewicz
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: CP-1729
Description
fixed removing more that 500 contacts when pure is protected via passcode
getState function in async thunk actions is correctly typed
redux selectors are used in components / prop drilling is reduce
Screenshots
// put images here