Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2192] I want to be informed about problem with connecting a device #1395

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

OskarMichalkiewicz
Copy link
Contributor

@OskarMichalkiewicz OskarMichalkiewicz commented Sep 21, 2023

Jira: CP-2192

Description

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce
Screenshots // put images here

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: -0.01% ⚠️

Comparison is base (ee2099d) 76.49% compared to head (d12f5d1) 76.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   76.49%   76.49%   -0.01%     
==========================================
  Files         919      919              
  Lines       13632    13634       +2     
  Branches     2035     2036       +1     
==========================================
+ Hits        10428    10429       +1     
  Misses       2624     2624              
- Partials      580      581       +1     
Files Changed Coverage Δ
...ls-manager/components/modals-manager.component.tsx 89.47% <ø> (-1.84%) ⬇️
...ecting/components/connecting-content.component.tsx 93.33% <75.00%> (-6.67%) ⬇️
...c/connecting/components/error-connecting-modal.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants