[CP-2191] I want only supported files to be uploaded #1393
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
+ Coverage 76.49% 76.51% +0.02%
==========================================
Files 919 921 +2
Lines 13634 13671 +37
Branches 2036 2039 +3
==========================================
+ Hits 10429 10461 +32
- Misses 2624 2628 +4
- Partials 581 582 +1
☔ View full report in Codecov by Sentry. |
github-actions
bot
requested review from
dkarski,
lkowalczyk87 and
patryk-sierzega
| ) | ||
| }) | ||
|
|
||
| return [validFiles, invalidFiles] |
There was a problem hiding this comment.
actually it doesn't matter at all, but why array of arrays not object with two fields? :D
There was a problem hiding this comment.
Maybe it would ease things to create function:
const isPathEligible = (path: string) => eligibleFormat.includes(
(path.split(".").pop() ?? "").toLocaleLowerCase()
and then use it in both filters? :D
There was a problem hiding this comment.
While writing this i had in mind the syntax of useState for example where as a return value you get something similar to tuple.
There was a problem hiding this comment.
still I think that object might be more descriptive + the filter function is a great idea. Working on it.
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "component.collectingDataModalBody": "I agree on sending anonymized data to Mudita" | |||
There was a problem hiding this comment.
isn't it suppose to be in polish? :D
There was a problem hiding this comment.
that was synced with phrase, i guess that's some legacy data that still lingers there
This reverts commit 06aa8d0.
Jira: CP-2191
Description
Screenshots
// put images here