Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-2086]The user can decline to upload files to the File Manager if they select more files than they can add within the limit [Harmony] #1390

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

OskarMichalkiewicz
Copy link
Contributor

@OskarMichalkiewicz OskarMichalkiewicz commented Sep 19, 2023

Jira: CP-2086

Description

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce
Screenshots // put images here

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (fa33fa5) 76.49% compared to head (b6f1919) 76.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1390      +/-   ##
==========================================
- Coverage   76.49%   76.49%   -0.01%     
==========================================
  Files         919      919              
  Lines       13625    13627       +2     
  Branches     2034     2034              
==========================================
+ Hits        10423    10424       +1     
- Misses       2622     2623       +1     
  Partials      580      580              
Files Changed Coverage Δ
...ents/modal-dialog/get-modal-dialog-style.helper.ts 70.58% <ø> (ø)
...ng-upload-modal/pending-upload-modal.component.tsx 65.21% <50.00%> (-1.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OskarMichalkiewicz OskarMichalkiewicz merged commit ffdd28e into master Sep 20, 2023
@OskarMichalkiewicz OskarMichalkiewicz deleted the CP-2086 branch September 20, 2023 07:19
dkarski pushed a commit that referenced this pull request Sep 27, 2023
…they select more files than they can add within the limit [Harmony] (#1390)
dkarski pushed a commit that referenced this pull request Sep 29, 2023
…they select more files than they can add within the limit [Harmony] (#1390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants