Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EGD-8018] Add Danish text input #3339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

snan
Copy link
Contributor

@snan snan commented Nov 28, 2021

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2021

CLA assistant check
All committers have signed the CLA.

@SP2FET
Copy link
Contributor

SP2FET commented Nov 29, 2021

Hi, thanks for contributing! We have to add a Jira ticket to your PR to be able to pass the CI checks, as right now it fails on commit check:

[bc57a2fe6ae010312f842c8329d280b20f8aef2b] invalid subject "Add Danish text input", should match format "^\[(EGD|BH|CP)-\d+\] [A-Z].+[^.]$"

@snan
Copy link
Contributor Author

snan commented Nov 29, 2021

Hi, thanks for contributing! We have to add a Jira ticket to your PR to be able to pass the CI checks, as right now it fails on commit check:

[bc57a2fe6ae010312f842c8329d280b20f8aef2b] invalid subject "Add Danish text input", should match format "^\[(EGD|BH|CP)-\d+\] [A-Z].+[^.]$"

If so, also update development_workflow.md to match ♥

@SP2FET
Copy link
Contributor

SP2FET commented Nov 29, 2021

Hi, thanks for contributing! We have to add a Jira ticket to your PR to be able to pass the CI checks, as right now it fails on commit check:

[bc57a2fe6ae010312f842c8329d280b20f8aef2b] invalid subject "Add Danish text input", should match format "^\[(EGD|BH|CP)-\d+\] [A-Z].+[^.]$"

If so, also update development_workflow.md to match hearts

It's already there:

Commits from the community will be accompanied by a relevant Jira ticket number during the merge. Don't add commits that are out of the scope of the Jira issue you are working on. You should have exactly one commit in a single PR.

Saying so - I've created a ticket for you, so you can update the commit's name with it:
EGD-8018

@SP2FET SP2FET assigned pholat and PrzeBrudny and unassigned pholat and PrzeBrudny Nov 29, 2021
@SP2FET SP2FET requested review from PrzeBrudny and pholat November 29, 2021 11:52
@SP2FET
Copy link
Contributor

SP2FET commented Nov 29, 2021

FYI - I've found something strange in our CI - probably temporary problem - that's why your check is "expected"
EDIT:
Should be fixed :)

@SP2FET SP2FET changed the title Add Danish text input [EGD-8018] Add Danish text input Nov 29, 2021
@SP2FET
Copy link
Contributor

SP2FET commented Dec 6, 2021

@snan If you rebase your branch, checks should be passed ;)

@SP2FET
Copy link
Contributor

SP2FET commented Dec 6, 2021

@snan please squash/fix those 2 commits - I'm keeping my eye on Jenkins right now - if the error persists after this, I'll take a look at it

@snan
Copy link
Contributor Author

snan commented Dec 6, 2021

God damned GitHub's web interface! It pulled with merge instead of pull --rebase. I'm trying to redo the rebase locally.

@SP2FET
Copy link
Contributor

SP2FET commented Dec 6, 2021

God damned GitHub's web interface! It pulled with merge instead of pull --rebase. I'm trying to redo the rebase locally.

what I did on my own fork was:

  • adding mudita origin for fork: git remote add-url mudita URL_HERE
  • fetching the "original" repo: git fetch mudita
  • rebasing to the main repo: git rebase mudita/master -i
  • pushing rebased branch to fork's origin: git push origin branch -f

Maybe it will help you with this and future rebases - it's simpler and quicker in my opinion ;)

@SP2FET
Copy link
Contributor

SP2FET commented Dec 6, 2021

@snan if you'll encounter more problems with this rebase you can always reach me via PM on our forum ;)

@SP2FET
Copy link
Contributor

SP2FET commented Dec 7, 2021

@snan FYI you've made a typo :P
EDG should be EGD ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants