Assorted C++ cleanup #102
Merged
Assorted C++ cleanup #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As RE2's NamedCapturingGroups returns a const reference to its map of names to indices, use that rather than immediately taking a copy. Switch to using iterators over the data where possible. Note we don't use auto for the types as that isn't available when compiling against the oldest versions of RE2.
Now we only support Ruby 2.6 and later, we can drop the various macros used to polyfill support for Ruby without RSTRING_LEN, encoding support, etc.
cpplint complains about the use of a non-const reference, instead recommending the use of a pointer when the argument will be mutated as in this case where we're setting various RE2::Options.
To make it clearer what is local to this file and which VALUEs will be mutated, use static for every function (except Init_re2) and use const VALUE where possible.
As re2::StringPiece (and absl::string_view in the most recent versions) can be used as both a std::string and a const char *, there's no need to create extra strings when we can use a C string directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to address some of the items from #59 and improve the C++ code of the extension.
Namely: