Skip to content

Commit

Permalink
ci: Fix Ruby 2.5 in arm64 builds
Browse files Browse the repository at this point in the history
Standardize on using the Alpine Ruby base images since they tend to
use a more recent version of glibc. Since Alpine images don't include
`bash` and `gcompat` by default, add a wrapper
(`scripts/test-gem-install-sh`) for Alpine.
  • Loading branch information
stanhu committed Sep 11, 2023
1 parent 9b32004 commit e9c6ca4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@ jobs:
- run: |
docker run --rm -v "$(pwd):/re2" -w /re2 \
--platform=linux/arm64/v8 \
ruby:${{matrix.ruby}} \
./scripts/test-gem-install ./gems
ruby:${{matrix.ruby}}-alpine \
./scripts/test-gem-install-sh ./gems
test-precompiled-arm-linux:
needs: ["build-precompiled-gems"]
Expand All @@ -263,8 +263,8 @@ jobs:
- run: |
docker run --rm -v "$(pwd):/re2" -w /re2 \
--platform=linux/arm/v7 \
ruby:${{matrix.ruby}} \
./scripts/test-gem-install ./gems
ruby:${{matrix.ruby}}-alpine \
./scripts/test-gem-install-sh ./gems
test-precompiled-x64-mingw-ucrt:
needs: ["build-precompiled-gems"]
Expand Down
9 changes: 9 additions & 0 deletions scripts/test-gem-install-sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#! /usr/bin/env sh
#
# run as part of CI
#
if [ -f /etc/alpine-release ]; then
apk add bash gcompat
fi

./scripts/test-gem-install $@

0 comments on commit e9c6ca4

Please sign in to comment.