Skip to content

Commit

Permalink
Update the system dependency tests to use the built gem
Browse files Browse the repository at this point in the history
This would better reflect how users might install the gem.
  • Loading branch information
stanhu committed Aug 30, 2023
1 parent b6ccbfc commit 7edf6ce
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:

jobs:
compile-and-test-system-dependencies:
needs: ["build-cruby-gem"]
name: System Dependencies - Ruby ${{ matrix.ruby }} - libre2 ABI version ${{ matrix.libre2.soname }}
runs-on: ubuntu-20.04
strategy:
Expand Down Expand Up @@ -57,8 +58,11 @@ jobs:
with:
ruby-version: "${{ matrix.ruby }}"
bundler-cache: true
- run: bundle exec rake compile -- --enable-system-libraries
- run: bundle exec rake spec
- uses: actions/download-artifact@v3
with:
name: cruby-gem
path: gems
- run: ./scripts/test-gem-install gems --enable-system-libraries

compile-and-test-vendored-dependencies:
name: Vendored Dependencies - Ruby ${{ matrix.ruby }} - ${{ matrix.runs-on }}
Expand Down
2 changes: 1 addition & 1 deletion scripts/test-gem-install
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ bundle install --local || bundle install

cd $(dirname `gem which re2`)
cd ..
rake spec
bundle exec rake spec

0 comments on commit 7edf6ce

Please sign in to comment.