Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail service tutorial update #13

Open
wants to merge 17 commits into
base: feature/add-auth
Choose a base branch
from

Conversation

piemonkey
Copy link

I had issues trying to get the mail service tutorial working inside mu-delta-service, so I realised it made more sense to base this update on the feature/add-auth branch, so I could use delta-notifier without having to write docs on how to set up mu-authorization. Right now this PR is very big, but that's because it's based on my tutorials branch, with the feature/add-auth branch merged in. If #12 is merged in and master merged into this branch, then those changes should disappear. If feature/add-auth is merged first, then I can rebase this PR onto the new master.

This fixes a few issues with the tutorial and makes it easily testable out of the box with a free email service (which I think was otherwise preventing people from actually using the tutorial code). I also added notes on how to test while working, to make the tutorial easier to follow along with and get working.

@Denperidge
Copy link
Contributor

Looks great!

@piemonkey piemonkey force-pushed the mail-service-update branch from 79a16ad to 88bc0a2 Compare October 17, 2023 09:48
@piemonkey piemonkey force-pushed the mail-service-update branch from 88bc0a2 to cab9d38 Compare October 17, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants