Remove parallel upserts for child entities #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbrunskill
commented
Mar 21, 2024
| }; | ||
| child_codes.push(child_entity.code); | ||
| )) | ||
| })??; |
There was a problem hiding this comment.
Is double ?? ok, or better to be explicit?
There was a problem hiding this comment.
Fine to me? If you're down in the weeds enough to care about one ?, you can probably notice two?
|
We still have an issue where a pending change might not be insertable in future, however I think it should now at least create the parent element first, so worst case we can reject a broken pending change an re-enter the other records. It would be possible for all entities to be inserted by their links could be missing. Not sure if there's a good way to handle without a transction. |
lache-melvin
approved these changes
Mar 21, 2024
jmbrunskill
deleted the
616-when-approving-drug-it-saved-itself-but-does-not-appear-in-the-drug-list-and-says-it-already-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616
Description
Discovered that parallel child node inserts seems to trigger dgraph transaction errors.
For some reason this was not seen with earlier inserts...
I've increased the retry time to 20ms, so hopefully increases the chances for the dgraph system to recover before retries kick in.
Tests:
I've tested adding Diclofenac as well as editing it.
I'm slightly concerned there was a reason I did children first, before parent but seems to work fine in this order...