Item total values #5906
Merged
Item total values #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size differenceComparing this PR to
|
This was referenced Dec 30, 2024
roxy-dao
approved these changes
Jan 2, 2025
| @@ -1712,12 +1714,12 @@ | |||
| "title.repack-details": "Repack Details", | |||
| "title.sensor-details": "Sensor Details", | |||
| "title.stock-line-details": "Stock Line Details", | |||
| "title.stock-on-hand": "Available Stock", | |||
| "title.stock-on-hand": "Stock on Hand", | |||
There was a problem hiding this comment.
Since our-soh says Our available Stock on Hand should this also say available stock on hand? 🤔
There was a problem hiding this comment.
no, this is correct. it's only used by the item stats panel and that's now showing total soh and not available soh.
Comment on lines
5
to
6
| import { ReasonOptionRowFragmentDoc } from '../../../../../packages/system/src/ReasonOption/api/operations.generated'; | ||
| import { NameRowFragmentDoc } from '../../../../../packages/system/src/Name/api/operations.generated'; |
There was a problem hiding this comment.
thanks. the gql generation threw a few curve balls.. it's still not totally reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5903
👩🏻💻 What does this PR do?
Required a bit more change than I was hoping for. This was a quick fix to make the labels consistent and it's taken a few more changes than expected.
Changes
Side quest
this bothers me:
So I've done a quick fix ( we intend to rework the left nav, so no reason to spend a long time on it )
Side quest
The stock view is showing a column with no label:
Perhaps due to the pack variant changes? I've fixed
💌 Any notes for the reviewer?
Please check the Russian translation for 'Stock on Hand' I've had to remove 'available' from translations and that one I wasn't sure about
🧪 Testing
📃 Documentation
1.
2.